Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Michael Koziarski's latest activity

Friday, December 18 2009
3472 AssociationCollection#include? ignoring build associated objects was updated in Ruby on Rails
  • Michael Koziarski
    Michael Koziarski commented at 9:05 AM

    This patch doesn't apply cleanly right now, could you rebase it for me

    However the change doesn't quite look right to me, shouldn't the check be whether the tar...

Monday, December 14 2009
3536 Separate tests for validate uniqueness with utf characters was updated in Ruby on Rails
  • Michael Koziarski
    • State changed from new to wontfix
    by Michael Koziarski at 8:37 PM

    UTF-8 support isn't an 'additional feature' though, if it doesn't work with those strings, it's broken.

    I'd prefer we left it as is lest people start thinking '...

3511 to_yaml fails for DateTime objects was updated in Ruby on Rails
Friday, December 11 2009
3559 Problem with XSS escape in select_* (eg: select_month) helpers was updated in Ruby on Rails
Wednesday, December 02 2009
3412 [Patch] Correctly handle instance_eval in association proxies was updated in Ruby on Rails
  • Michael Koziarski
    Michael Koziarski commented at 8:58 PM

    heh, lighthouse doesn't scale for parallel discussions!

    Yea, see if you can rejig the patch to just fix instance_eval and leave the others in place.

  • Michael Koziarski
    Michael Koziarski commented at 8:57 PM

    Of course it's possible that nothing else needs changing, in which case awesome!

  • Michael Koziarski
    • State changed from committed to open
    by Michael Koziarski at 8:56 PM

    Given we've decided to apply this anyhow, I feel it's important we investigate every other case where this patch introduced changes. The original is here:

    http...

  • Michael Koziarski
    • State changed from new to wontfix
    by Michael Koziarski at 8:36 PM

    These changes were added for performance reasons, If you're interested in the changeset and memory savings git blame will show them to you and alexander dymo's ...

Monday, November 30 2009
3448 Button_to does not return an HTML-safe string was updated in Ruby on Rails
2.3.6 was updated by Michael Koziarski in Ruby on Rails at 8:36 PM
 
0 of 106 tickets remain in this milestone